Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit with error, if user provides unused parameters #821

Closed
hannobraun opened this issue Jul 15, 2022 · 3 comments
Closed

Exit with error, if user provides unused parameters #821

hannobraun opened this issue Jul 15, 2022 · 3 comments
Labels
type: feature New features and improvements to existing features
Milestone
Basic Usability

Comments

@hannobraun
Copy link
Owner

Fornjot models can have parameters. The user can pass those to the app via the command-line interface, using --parameters.

If the user passes any parameters that the model doesn't use, maybe because of a typo or because the model has changed since the user last used it, that parameter is ignored. This is quite error-prone.

If the user passes a parameter that the model doesn't use, this should cause the app to exit with an appropriate error message. Detecting this requires a better interface between host and model. See #804, which this issue is currently blocked on.
@hannobraun hannobraun added type: feature New features and improvements to existing features status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance topic: model labels Jul 15, 2022
@hannobraun hannobraun added this to the Basic Usability milestone Jul 18, 2022
@Michael-F-Bryan
Copy link
Contributor

The metadata system mentioned in #804 (comment) would be quite useful here.

@hannobraun
Copy link
Owner Author

#804 has been addressed. This is no longer blocked.

@hannobraun hannobraun removed the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Aug 12, 2022
@hannobraun
Copy link
Owner Author

This issue is no longer applicable. The affected code has been removed. See A New Direction for context.

@hannobraun hannobraun closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature New features and improvements to existing features
Projects
None yet
Milestone
Basic Usability
Development

No branches or pull requests
2 participants
@hannobraun @Michael-F-Bryan