fj doesn't build with the serialization feature

[kamirr]

cargo build --features serialization fails as follows:

Build Log

error: cannot find derive macro `Serialize` in this scope
 --> crates/fj/src/angle.rs:8:46
  |
8 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
  |                                              ^^^^^^^^^

error: cannot find derive macro `Deserialize` in this scope
 --> crates/fj/src/angle.rs:8:57
  |
8 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
  |                                                         ^^^^^^^^^^^

error: cannot find derive macro `Serialize` in this scope
 --> crates/fj/src/shape_2d.rs:8:46
  |
8 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
  |                                              ^^^^^^^^^

error: cannot find derive macro `Deserialize` in this scope
 --> crates/fj/src/shape_2d.rs:8:57
  |
8 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
  |                                                         ^^^^^^^^^^^

error: cannot find derive macro `Serialize` in this scope
  --> crates/fj/src/shape_2d.rs:34:46
   |
34 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
   |                                              ^^^^^^^^^

error: cannot find derive macro `Deserialize` in this scope
  --> crates/fj/src/shape_2d.rs:34:57
   |
34 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
   |                                                         ^^^^^^^^^^^

error: cannot find derive macro `Serialize` in this scope
  --> crates/fj/src/shape_2d.rs:88:46
   |
88 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
   |                                              ^^^^^^^^^

error: cannot find derive macro `Deserialize` in this scope
  --> crates/fj/src/shape_2d.rs:88:57
   |
88 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
   |                                                         ^^^^^^^^^^^

error: cannot find derive macro `Serialize` in this scope
   --> crates/fj/src/shape_2d.rs:133:46
    |
133 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
    |                                              ^^^^^^^^^

error: cannot find derive macro `Deserialize` in this scope
   --> crates/fj/src/shape_2d.rs:133:57
    |
133 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
    |                                                         ^^^^^^^^^^^

error: cannot find derive macro `Serialize` in this scope
 --> crates/fj/src/shape_3d.rs:5:46
  |
5 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
  |                                              ^^^^^^^^^

error: cannot find derive macro `Deserialize` in this scope
 --> crates/fj/src/shape_3d.rs:5:57
  |
5 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
  |                                                         ^^^^^^^^^^^

error: cannot find derive macro `Serialize` in this scope
  --> crates/fj/src/shape_3d.rs:33:46
   |
33 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
   |                                              ^^^^^^^^^

error: cannot find derive macro `Deserialize` in this scope
  --> crates/fj/src/shape_3d.rs:33:57
   |
33 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
   |                                                         ^^^^^^^^^^^

error: cannot find derive macro `Serialize` in this scope
  --> crates/fj/src/shape_3d.rs:65:46
   |
65 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
   |                                              ^^^^^^^^^

error: cannot find derive macro `Deserialize` in this scope
  --> crates/fj/src/shape_3d.rs:65:57
   |
65 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
   |                                                         ^^^^^^^^^^^

error: cannot find derive macro `Serialize` in this scope
  --> crates/fj/src/shape_3d.rs:95:46
   |
95 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
   |                                              ^^^^^^^^^

error: cannot find derive macro `Deserialize` in this scope
  --> crates/fj/src/shape_3d.rs:95:57
   |
95 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
   |                                                         ^^^^^^^^^^^

error: cannot find derive macro `Serialize` in this scope
  --> crates/fj/src/lib.rs:32:46
   |
32 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
   |                                              ^^^^^^^^^

error: cannot find derive macro `Deserialize` in this scope
  --> crates/fj/src/lib.rs:32:57
   |
32 | #[cfg_attr(feature = "serialization", derive(Serialize, Deserialize))]
   |                                                         ^^^^^^^^^^^

error: could not compile `fj` due to 20 previous error

There are three issues responsible for this:

1. serde doesn't have the derive feature enabled in crates/fj/Cargo.toml.
2. Lacking use serde::{Serialize, Deserialize};.
3. Sketch uses raw pointers for managing its data, so the derive macros can't be used.

I'm working on a patch to address those.

[hannobraun]

Thanks for reporting this, @kamirr! Looking at your pull request right now.