Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors in a user-friendly way #68

Closed
hannobraun opened this issue Jan 21, 2022 · 2 comments
Closed

Handle errors in a user-friendly way #68

hannobraun opened this issue Jan 21, 2022 · 2 comments
Labels
topic: core Issues relating to core geometry, operations, algorithms type: feature New features and improvements to existing features
Milestone
Basic Usability

Comments

@hannobraun
Copy link
Owner

hannobraun commented Jan 21, 2022 •
edited
Loading

Right now, errors in the CAD model, whether legitimate errors due to user input, internal errors due to unimplemented functionality, or bugs, most likely lead to a panic. This crashes the host application which is not user-friendly:

  • The user might want to fix the error with a simple change to the model, and now has to restart the host application, instead of the model reloading automatically.
  • Unless the user starts the host application from a terminal, they might never even see the error message, just a silent crash.

Here's what I think we should do:

  • Any CAD kernel code should handle all errors correctly by returning Results.
  • At the top level, those results should be turned into friendly error messages and shown to the user in the UI.

Issue #69 is related. This is blocked on #116.
@hannobraun hannobraun added type: feature New features and improvements to existing features status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance topic: ui topic: core Issues relating to core geometry, operations, algorithms labels Jan 21, 2022
@hannobraun hannobraun added this to the Basic Usability milestone Jan 21, 2022
This was referenced Jan 21, 2022
Closed
Closed
Closed
@hannobraun
Copy link
Owner Author

No longer blocked. As of #763, we have support for egui now.

@hannobraun hannobraun removed the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Jul 11, 2022
@hannobraun
Copy link
Owner Author

This is mostly realized. The CAD kernel returns Results, and a lot of errors are now being shown in the UI. Any further issues should be tracked in more specific issues. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: core Issues relating to core geometry, operations, algorithms type: feature New features and improvements to existing features
Projects
None yet
Milestone
Basic Usability
Development

No branches or pull requests
1 participant
@hannobraun