Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop concept for configuration #38

Closed
hannobraun opened this issue Jan 18, 2022 · 1 comment
Closed

Develop concept for configuration #38

hannobraun opened this issue Jan 18, 2022 · 1 comment
Labels
status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance type: planning Issues about project planning

Comments

@hannobraun
Copy link
Owner

Right now, we don't have any persistent configuration. There are command-line parameters and some stuff in the UI, but no means to store configuration persistently.

Some thoughts:

  • At the heart of it should be a configuration file. I prefer TOML.
  • It might be useful to override configuration settings from the command line. Whether to do that manually, for selected settings, or whether there should be a CLI parameter that can systematically override any config setting, I don't know.
  • Where should that configuration file live? Something in .config on Linux (and the equivalent on other platforms) might be appropriate, but maybe users would also want to override user-level configuration on a per-model basis, using a local file. For a start, it might be best to just stick with a local file and see if there's need for something more advanced.
  • It would be great to be able to change settings from the GUI, but if there are multiple locations for configuration files, that poses the question how to GUI would handle that.
  • Maybe there is already a crate that handles that kind of stuff.

I wanted to open this issue to write down my thoughts (because the topic came up in #37), but it's probably best to wait until we have real use cases (marking as status: blocked until then). We can collect thoughts here in the meantime.

@hannobraun hannobraun added status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance type: development Work to ease development or maintenance, without direct effect on features or bugs topic: ui labels Jan 18, 2022
@hannobraun hannobraun added type: planning Issues about project planning and removed type: development Work to ease development or maintenance, without direct effect on features or bugs labels Jan 19, 2022
@hannobraun
Copy link
Owner Author

It's not clear what needs to be done here, and there are no use cases right now, that could provide such clarity. Added to feature wishlist. Closing as not actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance type: planning Issues about project planning
Projects
None yet
Development

No branches or pull requests

1 participant