Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting of fj crate is not checked #365

Closed
hannobraun opened this issue Mar 16, 2022 · 0 comments
Closed

Formatting of fj crate is not checked #365

hannobraun opened this issue Mar 16, 2022 · 0 comments
Labels
good first issue Good for newcomers topic: build Anything relating to the build system. type: development Work to ease development or maintenance, without direct effect on features or bugs

Comments

@hannobraun
Copy link
Owner

While the fj crate is included in the CI build, indirectly, because it's a dependency of fj-app, its formatting is not checked. Clippy probably doesn't run on it either.

It might be best to create a Cargo workspace and just add it, to make sure it's fully included in the build.
@hannobraun hannobraun added good first issue Good for newcomers type: development Work to ease development or maintenance, without direct effect on features or bugs topic: build Anything relating to the build system. labels Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers topic: build Anything relating to the build system. type: development Work to ease development or maintenance, without direct effect on features or bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hannobraun