Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clippy warnings #261

Closed
hannobraun opened this issue Feb 28, 2022 · 2 comments · Fixed by #266
Closed

Fix Clippy warnings #261

hannobraun opened this issue Feb 28, 2022 · 2 comments · Fixed by #266
Assignees
@hannobraun
Labels
good first issue Good for newcomers topic: build Anything relating to the build system. type: bug Something isn't working type: development Work to ease development or maintenance, without direct effect on features or bugs

Comments

@hannobraun
Copy link
Owner

#208 has added a check for Clippy warnings to the CI build. The code currently emits some warnings though, making the check fail: https://github.com/hannobraun/Fornjot/actions/runs/1910495131

These warnings should be either fixed or suppressed. I've taken a quick look and spotted nothing controversial that needs to be suppressed, so just fixing them as suggested by Clippy is probably fine.
@hannobraun hannobraun added type: bug Something isn't working type: development Work to ease development or maintenance, without direct effect on features or bugs topic: build Anything relating to the build system. good first issue Good for newcomers labels Feb 28, 2022
@hannobraun
Copy link
Owner Author

Adding https://github.com/hannobraun/Fornjot/labels/good%20first%20issue, as Clippy gives clear guidance for what needs to be done, and this might be a good introduction to various parts of the code.

@hannobraun hannobraun mentioned this issue Feb 28, 2022
Merged
@hannobraun
Copy link
Owner Author

This is getting on my nerves 😁

Started working on this.

@hannobraun hannobraun self-assigned this Feb 28, 2022
@hannobraun hannobraun mentioned this issue Feb 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannobraun hannobraun

Labels
good first issue Good for newcomers topic: build Anything relating to the build system. type: bug Something isn't working type: development Work to ease development or maintenance, without direct effect on features or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Clippy warnings hannobraun/fornjot
1 participant
@hannobraun