Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document limitations of shell-face sweeping #2162

Closed
hannobraun opened this issue Jan 16, 2024 · 1 comment
Closed

Document limitations of shell-face sweeping #2162

hannobraun opened this issue Jan 16, 2024 · 1 comment
Labels
good first issue Good for newcomers topic: core Issues relating to core geometry, operations, algorithms topic: documentation Improvements or additions to documentation type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

It is possible to sweep a specific face of a shell to extend the shell. See operations::sweep::shell_face for the implementation, and the split model for an example of using that capability.

This operation has some limitations, namely that any new faces generated must not coincide with existing ones. This should be clearly documented, preferably within the doc comment on the trait method of the operation.

Tagging as good first issue Good for newcomers , since this is a rather limited and documentation-only change. If anything is unclear, feel free to ask questions here!
@hannobraun hannobraun added topic: documentation Improvements or additions to documentation type: feature New features and improvements to existing features good first issue Good for newcomers topic: core Issues relating to core geometry, operations, algorithms labels Jan 16, 2024
@watana318 watana318 mentioned this issue Feb 13, 2024
Merged
@hannobraun
Copy link
Owner Author

Addressed by @watana318 in #2209. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers topic: core Issues relating to core geometry, operations, algorithms topic: documentation Improvements or additions to documentation type: feature New features and improvements to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hannobraun