Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider turning camera towards mouse cursor when zooming #20

Closed
hannobraun opened this issue Dec 7, 2021 · 7 comments
Closed

Consider turning camera towards mouse cursor when zooming #20

hannobraun opened this issue Dec 7, 2021 · 7 comments
Labels
type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

hannobraun commented Dec 7, 2021

When zooming, the camera could turn towards the mouse cursor. Maybe immediately, maybe at a limited turning speed, to make it feel less jarring.

I think this could make zooming (and camera navigation in general) a bit more intuitive.

@hannobraun hannobraun changed the title When zooming, the camera angle turns towards the focus point. Maybe immediately, maybe there's a limited turning speed, to make it feel less jarring. Consider turning camera towards focus point when zooming Dec 7, 2021
@hannobraun hannobraun added topic: input type: feature New features and improvements to existing features labels Dec 7, 2021
@hannobraun hannobraun changed the title Consider turning camera towards focus point when zooming Consider turning camera towards mouse cursor when zooming Feb 21, 2022
@hannobraun
Copy link
Owner Author

I realized that changing the camera direction while zooming is just about, well, direction, and has nothing to do with the focus point. Plus, it would be very confusing, if this behavior only worked while the mouse is pointing at the model. I've updated the issue title and description accordingly.

@ObiWanRohan
Copy link
Contributor

Is someone working on this @hannobraun?

@hannobraun
Copy link
Owner Author

Not to my knowledge, @ObiWanRohan, so this is free to take!

A word of warning though: Something's wrong with input right now. At least rotation sometimes feels very wrong. I think it's just #18, which might not affect this issue. But I also haven't looked into this recently, so yeah, no idea what is actually wrong.

I don't want to discourage you. Any help around input is very welcome! I'm just saying, you might be opening a can of worms 😁

@ObiWanRohan
Copy link
Contributor

@hannobraun I agree with you that this could just be #18 , which in turn needs #17 to be solved.
I will come back to this one after solving those two issues, since the steps in solving those are going to be needed to fix this issue.

@hannobraun
Copy link
Owner Author

Sounds great 👍

@hannobraun
Copy link
Owner Author

Hey @ObiWanRohan, I just wanted to note that there's some discussion about larger changes to the graphics/UI aspect going on in #491. This has the potential to disrupt any work that you might be doing on the input side, so if you're still interested in working on that, I suggest you take note.

@hannobraun
Copy link
Owner Author

I've decided to close this issue. fj-viewer is only a development tool now, and while improvements to rendering are still in scope and very welcome, I don't think it makes sense to have too many open issues to track potential usability improvements.

See A New Direction for context.

@hannobraun hannobraun closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New features and improvements to existing features
Projects
None yet
Development

No branches or pull requests

2 participants