Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that coincident HalfEdges are always congruent #1608

Closed
hannobraun opened this issue Feb 22, 2023 · 2 comments
Closed

Validate that coincident HalfEdges are always congruent #1608

hannobraun opened this issue Feb 22, 2023 · 2 comments
Labels
topic: core Issues relating to core geometry, operations, algorithms type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

HalfEdges that are coincident, i.e. located in the same space, must always be congruent. This means they must coincide exactly. The overlap must be complete. None of the coincident HalfEdges must overlap with just a section of another.

I discovered that the approximation code makes this assumption while working on #1605. It would be possible to fix this, but this assumption also enables some simplifications of the object graph. Which is why I've made the decision to confirm and document this limitation as a requirement, instead of lifting it. Given this decision, we should have validation code that upholds the requirement.

This might not be the right decision long-term, but it will work for now. And the simplifications it enables will certainly help us with any upcoming work. If it turns out that this requirement is too limiting, we can decide to lift it and add the required complexity to the kernel. But for now, I think this is the right call.

@hannobraun hannobraun added type: feature New features and improvements to existing features topic: core Issues relating to core geometry, operations, algorithms labels Feb 22, 2023
@hannobraun
Copy link
Owner Author

The issue description in missing some information on how to implement the validation. See this comment: #1697 (comment)

@hannobraun
Copy link
Owner Author

Closing in favor of #1937.

@hannobraun hannobraun closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Issues relating to core geometry, operations, algorithms type: feature New features and improvements to existing features
Projects
None yet
Development

No branches or pull requests

1 participant