Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove object iteration infrastructure #1427

Closed
hannobraun opened this issue Dec 7, 2022 · 0 comments · Fixed by #1480
Closed

Remove object iteration infrastructure #1427

hannobraun opened this issue Dec 7, 2022 · 0 comments · Fixed by #1480
Labels
topic: core Issues relating to core geometry, operations, algorithms type: development Work to ease development or maintenance, without direct effect on features or bugs

Comments

@hannobraun
Copy link
Owner

hannobraun commented Dec 7, 2022

The kernel contains infrastructure for iterating over other objects that an object references. This was introduced to support a previous version of the object validation infrastructure, but the current object validation infrastructure no longer uses that code.

This whole thing was always a bit dodgy. The implementation isn't great, and it's adds a significant (although not crazy) amount of complexity to the kernel. I think it would be better to remove it.

It's currently used in a few tests. I think it shouldn't be too hard to adapt these tests, but I haven't looked into it.

@hannobraun hannobraun added type: development Work to ease development or maintenance, without direct effect on features or bugs topic: core Issues relating to core geometry, operations, algorithms labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Issues relating to core geometry, operations, algorithms type: development Work to ease development or maintenance, without direct effect on features or bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant