Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to generate model #1271

Closed
hannobraun opened this issue Oct 26, 2022 · 2 comments · Fixed by #1344
Closed

Add command to generate model #1271

hannobraun opened this issue Oct 26, 2022 · 2 comments · Fixed by #1344
Labels
good first issue Good for newcomers type: feature New features and improvements to existing features

Comments

@hannobraun
Copy link
Owner

When someone wants to try Fornjot, there's not a great way to see something quickly, unless they're cloning the Git repository and use the example models in there. For that reason, and also to make it easier to get started in general, it would be great if the Fornjot app could generate an example model.

Eventually, this should be possible from within the app, but for now, a command-line argument would suffice. Maybe something like this:

fj-app model new <name>

This would generate a model in the <name>/ directory within the current one. The generated model should be something simple. cuboid or spacer could be good candidates. Maybe even star. It doesn't actually matter much. Once the infrastructure is in place, it should be easy to change which model is being generated.

Ideally, the generated model should be regularly tested, so it doesn't become stale. Maybe including one of the example models directly in the binary using something like include_dir would be an option. Those are part of the CI build, so they should always be in sync with the app.

Labeling https://github.com/hannobraun/Fornjot/labels/good%20first%20issue. This will require some figuring out and design decisions, but as far as Fornjot is concerned, it only requires surface knowledge. The place to add the command-line argument is args.rs in fj-app, and any of the code for generating the model can just go into a new module within fj-app.

@hannobraun
Copy link
Owner Author

I've just removed this feature again in #1373. See #1356 for context.

Reopening.

@hannobraun hannobraun reopened this Nov 21, 2022
@hannobraun
Copy link
Owner Author

This issue is no longer applicable. The affected code has been removed. See A New Direction for context.

@hannobraun hannobraun closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: feature New features and improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant