You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While it makes sense to distinguish these official binaries from user-compiled ones, the "unreleased" here is confusing.
The version is currently controlled by fj-app's build.rs. Maybe it can be adapted to detect cargo install and create a more informative version string in that case? If not, maybe "unreleased" can be replaced with something more informative.
The text was updated successfully, but these errors were encountered:
It would be nice to somehow note that the binary was cargo installed, but that doesn't seem practical. At least I could find no way to get access to that information in build.rs.
In any case, even though the version output is far from perfect, this specific issue has been addressed. Closing.
You can install a crates.io release of
fj-app
like this:cargo install fj-app
If you then run
fj-app --version
, it says something like this:Official release binaries built by the release automation don't say "unreleased". This is controlled by setting an environment variable:
https://github.com/hannobraun/Fornjot/blob/49d3ac0d3795ccc20403e322c56e59570bc32e86/.github/workflows/cd.yml#L14-L16
While it makes sense to distinguish these official binaries from user-compiled ones, the "unreleased" here is confusing.
The version is currently controlled by
fj-app
'sbuild.rs
. Maybe it can be adapted to detectcargo install
and create a more informative version string in that case? If not, maybe "unreleased" can be replaced with something more informative.The text was updated successfully, but these errors were encountered: