Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of cargo installed fj-app says "unreleased" #1236

Closed
hannobraun opened this issue Oct 19, 2022 · 1 comment
Closed

Version of cargo installed fj-app says "unreleased" #1236

hannobraun opened this issue Oct 19, 2022 · 1 comment
Labels
topic: build Anything relating to the build system. type: bug Something isn't working

Comments

@hannobraun
Copy link
Owner

You can install a crates.io release of fj-app like this: cargo install fj-app

If you then run fj-app --version, it says something like this:

fj-app 0.20.0 (unreleased)

Official release binaries built by the release automation don't say "unreleased". This is controlled by setting an environment variable:
https://github.com/hannobraun/Fornjot/blob/49d3ac0d3795ccc20403e322c56e59570bc32e86/.github/workflows/cd.yml#L14-L16

While it makes sense to distinguish these official binaries from user-compiled ones, the "unreleased" here is confusing.

The version is currently controlled by fj-app's build.rs. Maybe it can be adapted to detect cargo install and create a more informative version string in that case? If not, maybe "unreleased" can be replaced with something more informative.

@hannobraun hannobraun added type: bug Something isn't working topic: build Anything relating to the build system. labels Oct 19, 2022
@hannobraun
Copy link
Owner Author

This issue is no longer up-to-date. This is the output now (as of #1367):

$ fj-app --version
fj-app 0.28.0 (development build)

It would be nice to somehow note that the binary was cargo installed, but that doesn't seem practical. At least I could find no way to get access to that information in build.rs.

In any case, even though the version output is far from perfect, this specific issue has been addressed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Anything relating to the build system. type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant