Extend status report element #919
Conversation
There was a problem hiding this comment.
Thank you, @devanlooches!
Do you think this could be placed into a corner (lower-right? doesn't matter, maybe), and made more broad than high? Then there would be fewer line breaks in the error message.
What else would you like me to include in the status update element
No more ideas right now, but now that we have it, it's easy to add more when we need to 👍
and also why did you want me to make it hold a vector?
I figured then we could display the last few status messages, and not just the last one.
|
Thanks for the feedback!
We could place it there but the element is supposed to auto resize itself to the contents (I don't know why it breaks the error message). But it is also stretchable so you can extend it horizontally by dragging the edge outwards.
How many status messages do you think should be kept before clearing it? |
|
I could make the element completely draggable that way the user can put wherever they want. |
There was a problem hiding this comment.
Thank you for the additional commits, @devanlooches, looks good!
We could place it there but the element is supposed to auto resize itself to the contents (I don't know why it breaks the error message). But it is also stretchable so you can extend it horizontally by dragging the edge outwards.
Hmm, when I grab it at its edge, I can move it, but not resize it. After I stop pressing the left mouse button, it resets to its original position.
I could make the element completely draggable that way the user can put wherever they want.
That might be ideal! Is that easy to do?
How many status messages do you think should be kept before clearing it?
I don't know. Maybe 5?
It doesn't really matter. Once the mechanism is there to store/display multiple messages and limit them to a certain number, it's easy to adjust that number later, as we gain more experience with it.
|
Cool I will implement all of this shortly its a pretty quick fix. Edit: Mostly :) |
|
Nice, thank you! |
|
Here is the fix. Unfortunately I'm having trouble putting the window on the bottom right by default (and still having it able to be dragged). If anyone could help me with that it would be great. |
|
One other thing I was thinking is it might be a good idea to keep the 5 status messages unless there is a compiler error in which case it might be a good idea to clear them in order to save space for the compiler error message (And also not show it more than once). |
|
Thank you, @devanlooches, I'll take a look later! |
There was a problem hiding this comment.
Thanks for the latest changes, @devanlooches! And sorry for the delay; I was out and about for much of the weekend.
Unfortunately I'm having trouble putting the window on the bottom right by default (and still having it able to be dragged). If anyone could help me with that it would be great.
Unfortunately I don't know either (I don't have much experience with egui). We can always improve it later! (And maybe the lower-right corner isn't even the best location.)
One other thing I was thinking is it might be a good idea to keep the 5 status messages unless there is a compiler error in which case it might be a good idea to clear them in order to save space for the compiler error message (And also not show it more than once).
That sounds good!
I think it makes sense to distinguish between different kinds of status updates (info, error, etc.) and make decision based on what types we currently have.
I'm merging this now! There's still room for improvement, of course, but this is already much better than what we currently have. Thanks you again, @devanlooches!
| if self.status.len() >= 5 { | ||
| self.clear_status(); | ||
| } |
There was a problem hiding this comment.
I think this implementation is a bit weird, as it results in lots of statuses being removed at once. Might be better to just remove the oldest status, until only 5 are left. Maybe VecDeque is a better type for this than Vec, as it provides convenient push_back/pop_front methods.
But that's something that can be fixed later.
There was a problem hiding this comment.
No problem! Thanks for the feedback! Your right, VecDeque does look convenient. I'll look into it.
Right now I added the full error inside of a stretchable and scrollable element on a right side bar.
What else would you like me to include in the status update element and also why did you want me to make it hold a vector?