Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mesh and debug rendering checkboxes if line drawing is unavailable #914

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

hekno25
Copy link
Contributor

@hekno25 hekno25 commented Aug 4, 2022

This is to address #907. The changes do work (tested by making is_line_drawing_available return false always) but I doubt this is the best way to do it. Any alternatives/improvements are welcome.

edit by @hannobraun:
Close #907

@hekno25 hekno25 requested a review from hannobraun as a code owner August 4, 2022 04:54
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @hekno25! Looks and works great!

I'm no egui expert, but I can't think of a better way to do this. And I'm very happy with how the hover text turned out. I feared that maybe it might be easy to miss, but it's very obvious.

@hannobraun hannobraun merged commit cf76fee into hannobraun:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it clear in UI, when graphics features are not available
2 participants