-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI element that displays model compiling status #911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @devanlooches!
This looks almost good to merge now, but the CI build still fails, specifically the cargo fmt
and cargo clippy
steps.
You should be able to take care of formatting automatically by running cargo fmt
and just committing the result. You can fix the Clippy error by running cargo clippy
and following its suggestion.
To get a feel for whether the CI build will pass, you can run just build
locally, as documented here: https://github.com/hannobraun/Fornjot/blob/main/CONTRIBUTING.md#making-improvements
For some reason the CI build passes. However locally when I ran just build it failed with a linker error on the export validator step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @devanlooches, looks good!
Oh, I forgot to reply to this:
That's sounds like a bug! Could you open an issue with the full error message? Maybe it's something platform-specific, or I have something installed that's missing on your machine. |
No description provided.