Add new builder API #866
Merged
Add new builder API #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it makes sense to have all methods for building an object come first, the messages for accessing the built object after.
This is only a first step towards establishing a new builder API.
This new `FacePolygon` struct isn't fully formed yet. It will be used to provide more capabilities to the builder API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new builder API to replace the previous one, which had been removed. This new builder API provides two immediate advantages:
The main feature, however, are the new wrapper structs that this new style of API enables, represented here by
FacePolygon. This aspect isn't fully formed yet, but eventually, there will be more such wrapper objects, and they will provide services beyond just building the object. For example, I'm currently working on aCubewrapper struct, that provides methods likebottom_face,top_face, etc.This is going to mesh well with the object update API I'm currently working on (no issue open yet; still exploring the design space). With this update API and the new builder API, you will be able to create a cube, select one of its faces, and make modifications there. This is going to be highly useful for test code.