Clean up Face
#855
Merged
Clean up Face
#855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Face::brep` is no longer part of the public interface, and I prefer to to have it below the other methods that call it.
Clippy doesn't actually warn about that, but it's going to, after I'm making a change I'm currently working on.
It used to serve a purpose, but no longer carries its weight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
Faceand make representation mostly an implementation detail. This eases the use of faces with boundary representation, at the cost of some type safety. I think this is the right trade-off for now. Return references fromFace's accessor methods. Clean up other things, as required.