Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make using models more convenient #832

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

Michael-F-Bryan
Copy link
Contributor

This adds PartialEq bounds to the geometry types in fj (fixes #831) and also makes it easier to populate a Parameters dictionary (calling .to_string() all the time can be annoying).

@hannobraun
Copy link
Owner

Thank you, @Michael-F-Bryan! I'll take a look later.

hannobraun
hannobraun previously approved these changes Jul 18, 2022
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Michael-F-Bryan, looks good!

Will rebase/merge when #828 is merged.

@hannobraun
Copy link
Owner

Ah, now we got a conflict, and I'm running out of time for today. Feel free to rebase, @Michael-F-Bryan. If not, I can take a look tomorrow.

@Michael-F-Bryan
Copy link
Contributor Author

@hannobraun, I've rebased onto main.

@hannobraun
Copy link
Owner

Thank you!

@hannobraun hannobraun merged commit 58bc1b2 into hannobraun:main Jul 18, 2022
@Michael-F-Bryan Michael-F-Bryan deleted the conveniences branch July 18, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shape types should implement equality
2 participants