Only calculate focus point when needed #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @jeevcat! I'll take a closer look later, but this seems like a nice improvement. |
hannobraun
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Just tested this. Works as great as it looks. Thank you, @jeevcat!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on every type of input event (include mouse movement), the focus point is calculated. This can be an expensive operation for complex meshes.
If the mouse is moved just right (try small circular motions), many mouse movement events will be triggered, each causing a focus point recalculation. All of these mouse movement events must be handled before a new frame is rendered.
This PR just moves focus point calculation into the mouse click events which need it, preventing the much more frequent mouse movement events from triggering the calculations.