Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup on PR #682 (fj serialization) #685

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Followup on PR #682 (fj serialization) #685

merged 3 commits into from
Jun 13, 2022

Conversation

kamirr
Copy link
Contributor

@kamirr kamirr commented Jun 13, 2022 •
edited by hannobraun
Loading

  1. Address the ordering of dependencies in fj
  2. Add fj and fj-proc to default-members so that just build takes them into account
  3. Make sure that the tests use --all-features

Besides cleaning up #682, this addresses #683 and #684.

I've verified the changes, other than the CI. I'll check the results for this PR to make sure that it works as intended.

edit by @hannobraun:
Close #683
Close #684

kamirr added 3 commits June 12, 2022 10:09
@kamirr
fj: move dev-dependencies to the end of Cargo.toml
7dda074
@kamirr
Add fj and fj-proc to default-members
5a01d77 
Without this the tests from these crates won't run in CI.
@kamirr
CI: cargo {build,clippy,test} need --all-features
aa6f13e 
This is so that no code is skipped during testing.
@kamirr kamirr requested a review from hannobraun as a code owner June 13, 2022 11:35
@kamirr kamirr changed the title Followup on PR #682 Followup on PR #682 (fj serialization) Jun 13, 2022
@kamirr
Copy link
Contributor Author

kamirr commented Jun 13, 2022

Ok, looking at the CI results it appears that cargo build/test/clippy are all invoked with the --all-features flag as intended.

1 similar comment
@kamirr

This comment was marked as duplicate.

Sign in to view
hannobraun
hannobraun approved these changes Jun 13, 2022
View reviewed changes
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kamirr, looks great!

@hannobraun hannobraun merged commit cd120d2 into hannobraun:main Jun 13, 2022
@kamirr kamirr deleted the fix_fj_serialization2 branch June 13, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannobraun hannobraun hannobraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some crates are missing from default-members in Cargo.lock CI build should enable all features
2 participants
@kamirr @hannobraun