Proc me up again #652
Merged
Proc me up again #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gabsi26 <[email protected]>
Signed-off-by: gabsi26 <[email protected]>
Signed-off-by: gabsi26 <[email protected]>
If no `default` is supplied now the parameter needs to be given. `min` and `max` no longer contribute as replacement `default`. Automatic checks for minimum and maximum added Signed-off-by: gabsi26 <[email protected]>
Signed-off-by: gabsi26 <[email protected]>
Signed-off-by: gabsi26 <[email protected]>
Signed-off-by: gabsi26 <[email protected]>
Signed-off-by: gabsi26 <[email protected]>
If no `default` is supplied now the parameter needs to be given. `min` and `max` no longer contribute as replacement `default`. Automatic checks for minimum and maximum added Signed-off-by: gabsi26 <[email protected]>
Signed-off-by: gabsi26 <[email protected]>
hannobraun
approved these changes
Jun 1, 2022
|
Currently if a user decides not to supply any metadata an annotation like |
|
Yes, that sounds reasonable, @gabsi26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #643 dealing with some of the suggestions provided there.
Now the possible annotations for an argument are permutations of
default,min,maxwith=and a value as well as empty or no parentheses.If supplied min and max values are automatically checked.
No implicit determination of default values takes place anymore