Add serde serialization to fj.
#610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
force-pushed
the
feature/shape-serialization
branch
from
9b421b4 to
34f5e89
Compare
hannobraun
approved these changes
May 20, 2022
There was a problem hiding this comment.
Thank you, @freylint, look great!
This doesn't seem to have any adverse effect on the compile times, so I'm happy to have it. I've left one comment with a suggestion. Feel free to address that in a follow-up PR or not. I'll merge this either way, once the CI build is green.
|
|
||
| [features] | ||
| default = [] | ||
| serialization = ["serde"] |
There was a problem hiding this comment.
I think we don't need an explicit feature here. Just having the implicit serde feature should be enough, and is what I've seen in other crates in the Rust ecosystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds serde as an optional dependency to
fj.I ran into the need this for while marshaling
Shapes between javascript and rust for the wasm32-unknown-unknown platform.I believe implementing serde on crates like this is also considered idiomatic. I'm not sure if this implementation is the exact idiomatic way to accomplish that.