Fix triangulation issues regarding point-in-polygon test #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This struct is specifically made for the point-in-polygon test. It it simpler than the currently used ray from Parry, allowing it to be more robust, and most importantly, provide exactly the feedback that the point-in-polygon test needs in a robust manner.
This leaves one known edge case unfixed, and that's passing through a vertex at the seam of the polygon in the presence of interior polygon chains. I'm going to fix that in a follow-up commit, as that's going to require some additional cleanup.
The ray leaving the polygon through the seam, was not detected in the presence of multiple polygonal chains. Now it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request mostly rewrites the point-in-polygon test, adding a test suite to provide some assurance. The point-in-polygon test was responsible for one class of triangulation bugs that seems to have cause pretty wide-spread issues.
Close #105
Close #143