Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config_ui): fix warning because of missing finish() call #397

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix(config_ui): fix warning because of missing finish() call #397

merged 1 commit into from
Mar 24, 2022

Conversation

liubog2008
Copy link
Contributor

@liubog2008 liubog2008 commented Mar 24, 2022 •
edited
Loading

Fix warning as below.

  2022-03-23T08:06:42.578774Z  WARN wgpu_core::device::queue: Dropped buffer has a pending mapping.

See example in https://github.com/hecrj/wgpu_glyph/blob/master/examples/hello.rs

Related issue: #157

@liubog2008 liubog2008 requested a review from hannobraun as a code owner March 24, 2022 10:10
hannobraun
hannobraun approved these changes Mar 24, 2022
View reviewed changes
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @liubog2008, this is great!

I didn't consider that those warnings could be coming from wrong use of wgpu_glyph!

@hannobraun hannobraun merged commit 41eb5ec into hannobraun:main Mar 24, 2022
@hannobraun hannobraun mentioned this pull request Mar 24, 2022
Closed
@liubog2008 liubog2008 deleted the fix-warning branch March 25, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannobraun hannobraun hannobraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liubog2008 @hannobraun