Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flake.lock #1687

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Update flake.lock #1687

merged 1 commit into from
Mar 16, 2023

Conversation

A-Walrus
Copy link
Contributor

Nix flake was out-of-date since rust-toolchain was raised to 1.68, but flake.lock was older than that. Ran nix flake update. In the future when raising rust-toolchain version we need to make sure that we update the flake as well

Nix flake was out-of-date since rust-toolchain was raised to 1.68, but
flake.lock was older than that. Ran `nix flake update`. In the future
when raising rust-toolchain version we need to make sure that we update
the flake as well
@A-Walrus A-Walrus requested a review from hannobraun as a code owner March 16, 2023 06:53
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @A-Walrus, looks good!

In the future when raising rust-toolchain version we need to make sure that we update the flake as well

I don't use Nix, and don't really maintain the Nix flake. But I agree that it would be better to keep the flake up-to-date.

Some thoughts:

  • I usually update to the latest stable Rust version pretty soon after it comes out. You and/or other Nix users could track the latest Rust releases and update the flake each time.
  • Alternatively, I could update the Nix flake each time I update the Rust version. But there are challenges:
    • I need to remember that I need to do it: Maybe we can make sure of that by adding a check to the CI build.
    • I need to remember what to do: There could maybe be a procedure file (similar to release-procedure.md) that documents how to upgrade the Rust version. (If we added such a file, it probably makes sense to add a procedures/ directory and move the release procedure there too.)
  • It would be even nicer if all of that were completely automated.
    • Maybe a command can be added to automator that makes all the necessary changes and creates a pull request.
    • It would be even more convenient, if we had a bot that did that whenever a new Rust version comes out. But I don't know if I wanna deal with hosting that bot somewhere.

Whatever solution we end up with, this is something that a contributor would have to drive (whether that means implementing the automation, or just writing a document that tells me what to do).

@hannobraun hannobraun merged commit fe28af5 into hannobraun:main Mar 16, 2023
@A-Walrus A-Walrus deleted the update_flake branch September 25, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants