Unify GlobalEdge and PartialGlobalEdge
#1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is preparation for removing the `Default` bound from `PartialObject`, which is getting in the way of my current work.
It's going to be needed there soon.
It's going to be needed there soon.
It's going to be needed there soon.
It's going to be needed there soon.
This is preparation for replacing the first partial objects with their full variants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or, to be more precise, just remove
PartialGlobalEdge, sinceGlobalEdgedidn't require any changes to make this happen. This did require a lot of changes to the partial object infrastructure though. Those weren't specific toGlobalEdge/PartialGlobalEdgethough, and should help with any future full/partial object unification.This is a first step towards achieving #1570.