Prepare for next step in HalfEdge simplification
#1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those tests are a constant thorn in my side. They resist every refactoring I do, and always need to be carefully massaged to keep working. I'm facing another of those moments, and I have enough. The results of the sweep are somewhat easy to inspect manually, and in combination with validation checks and export validation, it should be easy enough to keep the sweep code under control, despite the lack of direct automated testing. This is not ideal, of course. But I need to make progress. And since the sweep code will likely not survive the coming clean-ups in its current form anyway, it probably makes more sense to build up a new test suite in parallel to whatever the rewritten sweep code ends up being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resumes the work on #1525. It prepares lots of code for the next step of the
HalfEdgesimplification, only storing a singleSurfaceVertexperHalfEdge.