New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require an aspect ratio when creating a new NavigationCubeRenderer #1584

Merged

hannobraun merged 1 commit into hannobraun:main from erenoku:navigation_cube

Feb 14, 2023

Contributor

erenoku commented Feb 13, 2023

When the NavigationCubeRenderer is created for the first time just use an identity matrix as the mvp_matrix_buffer.


          Don't require an aspect ratio when creating a NavigationCubeRenderer

e2f0fdc

erenoku requested a review from hannobraun as a code owner

February 13, 2023 17:13

hannobraun approved these changes

View reviewed changes

Owner

hannobraun left a comment

Thank you, @erenoku! Nice simplification!

hannobraun merged commit 107a0c3 into hannobraun:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet