Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Status message window #1551

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Fixed Status message window #1551

merged 2 commits into from
Jan 31, 2023

Conversation

tmayoff
Copy link
Contributor

@tmayoff tmayoff commented Jan 31, 2023

Recently came across this project and wanted to contribute, it's not much but this should be improve the status message and close #1508. Let me know if there's anything you'd like me to change.

image
image

@tmayoff tmayoff requested a review from hannobraun as a code owner January 31, 2023 01:18
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tmayoff, looks awesome!

it's not much

Even small contributions are extremely valuable! I simply don't have the time to do everything, and there's a lot I don't know (for example, I'm not super-familiar with egui, and probably wouldn't have thought to use egui::Window here).

Lots of things that are good in Fornjot today exist because of small contributions that were later build upon by others!

@hannobraun hannobraun enabled auto-merge (squash) January 31, 2023 11:38
@hannobraun hannobraun merged commit 97881db into hannobraun:main Jan 31, 2023
@tmayoff tmayoff deleted the status branch January 31, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status messages can take up too much space
2 participants