Fix app crashing, if it is minimized too long #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgpu would fail after the window had been minimized and was un-minimized again after a while, because `Gui::update` would run many times while minimized, but `Gui::prepare_draw` wouldn't. That would lead to `end_frame` not being called for a long time, which in turn would lead to egui accumulating output. After that went on for a while, and `prepare_draw` was called again, there would be too much output for the index buffer to handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1499
Thanks go to @kazatsuyu, who helped me figure out what was wrong and suggested the fix!