Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Debug implementation of Handle #1298

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Improve Debug implementation of Handle #1298

merged 3 commits into from
Nov 2, 2022

Conversation

hannobraun
Copy link
Owner

By default, Handle has a very minimal Debug output:

println!("{global_vertex:?");
// prints:
// GlobalVertex @ 0x7f3e24305d40

Its Debug implementation now respects #, and will print full output if it is present:

println!("{global_vertex:#?");
// prints:
// GlobalVertex @ 0x7f3e24305d40 => GlobalVertex {
//     position: [
//         0.0,
//         0.0,
//         0.0,
//     ],
// }

This is going to be required for an improvement I'm about to commit.
It's been made redundant by `Handle`'s improve `Debug` implementation.
@hannobraun hannobraun enabled auto-merge November 2, 2022 10:50
@hannobraun hannobraun merged commit bc57d86 into main Nov 2, 2022
@hannobraun hannobraun deleted the handle branch November 2, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant