Clean up CI build #1259
Merged
Clean up CI build #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's lots of duplication between all of them, and all of their runtimes are dominated by the setup costs of the runners. I don't think getting the separate reporting for each is worth it.
We have a `rust-toolchain.toml` in the repository, and `rustup` is installed on GitHub Actions, as far as I know. I think this should just do the right thing. We might lose caching with this, but I'm not sure that's worth it. Maybe once there is a maintained `actions-rs` alternative.
It's unmaintained[1] and I honestly don't even know what it does. [1]: actions-rs/toolchain#216
No need to run this multiple times per build.
This was the original source, but we've divered from it a lot. The comment is probably more confusing than helpful at this point. And the attribution is immortalized in the commit log anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the CI build configuration, removing lots of duplication and unnecessary actions. It even seems to be a performance win, judging from the first results while building this pull request.