Remove HalfEdge::from_curve_and_vertices
#1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This constructor is a bit problematic, for multiple reasons: - It fulfills a role that is better fitted for the builder API. - It takes away control over the `GlobalVertex` construction from the caller. That second point is a problem, due to the work that needs to happen to address #1079. This commit doesn't solve that, but the builder API provides a better framework to do so than this constructor did.
hannobraun
force-pushed
the
ready/edge-constructor
branch
from
d73e40d to
adf1017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constructor is problematic. Citing one of the commit messages: