Dumb down RangeOnPath
#1094
Merged
Dumb down RangeOnPath
#1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare it for further additions.
The previous implementation didn't actually use the full number of vertices to approximate the circle, discarding the last one.
It seems less error-prone to me, to dumb down `RangeOnPath` and handle range direction in `PathApproxParams::points`.
It has been dumbed down so much, that the API it still had no longer made sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
RangeOnPathand concentrate all the complexity regarding ranges in one function. This feels less error-prone to me, as the caller of the API can't do anything wrong any more. Also, it seems to fix a bug I'm observing in a local branch, where approximated points were in the wrong direction (although I don't know what that bug was specifically; I do know this change fixes it).