Simplify cycle/edge/curve approximation code #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there is always going to be a next edge in the cycle, whose first point is the previous edge's last point, there is no need to include the last point in the approximation in the first place.
The function existed only for the test, but now I'm not sure how to uphold its properties that made it testable going forward. I think just removing the test is an okay solution for now, since there are higher-level tests covering the same code.
This serves no purpose, except making further changes I have in mind easier.
With this commit, all curve approximations work the same now, making edge approximation much simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reshuffles responsibilities between cycle, edge, and curve approximation. Aligns the approximation code for the different curve types, greatly simplifying edge approximation.
The resulting code is a bit more elegant, leading to a reduction in lines of code and complexity. It also paves the way for simplifying edge representation by removing the "continuous edge" edge case (no pun intended).