Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement intersection operation #44

Closed
hannobraun opened this issue Jan 19, 2022 · 6 comments
Closed

Implement intersection operation #44

hannobraun opened this issue Jan 19, 2022 · 6 comments
Labels
status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance topic: core Issues relating to core geometry, operations, algorithms type: feature New features and improvements to existing features
Milestone
Straight edges, f...

Comments

@hannobraun
Copy link
Owner

It should be possible to create the intersection of two shapes, using constructive solid geometry (CSG). This is currently not supported.

Implementing this requires more solid infrastructure in the host application for storing and querying shapes. Also see #42 and #43.
@hannobraun hannobraun added type: feature New features and improvements to existing features topic: core Issues relating to core geometry, operations, algorithms labels Jan 19, 2022
This was referenced Jan 19, 2022
Closed
Closed
@hannobraun
Copy link
Owner Author

Blocked on #97.

@hannobraun hannobraun added the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Jan 27, 2022
@hannobraun hannobraun mentioned this issue Feb 2, 2022
Closed
@hannobraun
Copy link
Owner Author

This is no longer blocked on #97!

@hannobraun hannobraun removed the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Mar 21, 2022
@hannobraun hannobraun mentioned this issue Jul 9, 2022
Closed
@hannobraun hannobraun mentioned this issue Aug 11, 2022
Closed
@hannobraun
Copy link
Owner Author

This is now blocked on #993. The same algorithm that's needed for #42 is needed for this too.

@hannobraun hannobraun added the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Aug 24, 2022
@hannobraun hannobraun mentioned this issue Aug 30, 2022
Closed
@hannobraun
Copy link
Owner Author

#993 has been addressed. This issue is no longer blocked!

@hannobraun hannobraun removed the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Sep 29, 2022
@hannobraun
Copy link
Owner Author

This operation will share much of its implementation with the union operation (#42), and I've recently labeled this as blocked, then no longer blocked, for the same reasons that #42 was blocked during that time frame. Now #42 is blocked again.

Instead of adding and removing the https://github.com/hannobraun/Fornjot/labels/status%3A%20blocked label a bunch of more times, I'm going to simply label this as https://github.com/hannobraun/Fornjot/labels/status%3A%20blocked on #42. Even though that isn't completely accurate, it will prevent this issue from seeing the same block/unblock churn that #42 is seeing. In addition, it wouldn't make sense to start work here anyway, right now. The groundwork required is the same that #42 requires, so it really makes no sense to start working on this issue in parallel.

@hannobraun hannobraun added the status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance label Sep 30, 2022
@hannobraun hannobraun mentioned this issue Nov 24, 2022
Closed
@hannobraun
Copy link
Owner Author

I've moved boolean operations to the feature wishlist and decided to close this issue. See explanation in #42.

@hannobraun hannobraun closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: blocked Issue or pull request is blocked by another issue or pull request, or some outside circumstance topic: core Issues relating to core geometry, operations, algorithms type: feature New features and improvements to existing features
Projects
None yet
Milestone
Straight edges, flat faces, simple sk...
Development

No branches or pull requests
1 participant
@hannobraun