Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy rng #41

Open
yallup opened this issue Jul 19, 2024 · 0 comments
Open

Legacy rng #41

yallup opened this issue Jul 19, 2024 · 0 comments

Comments

@yallup
Copy link
Collaborator

yallup commented Jul 19, 2024

Describe the bug
Currently lsbi uses legacy rng capabilities in numpy
Suggestion is to give all instances of model a seed and follow recommendations:
https://numpy.org/doc/stable/reference/random/generator.html

Why
Want to create reference “random” test cases, i.e. a fixed seed for model parameters. However this legacy seeding needs to be set globally, the users script owns the random number generator rather than the Generative Model, I’m not sure this is the best design and I could see this causing problems

design seems slightly tricky as multivariate_normal in the lsbi code would need to take a generator as argument then?
Thoughts welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant