-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict upper limit of pandas and matplotlib + "use latest versions" test #343
Comments
Yes, numpy and scipy should not be issues. It is matplotlib and pandas, since we are very closely linked with those.
As long as there are tests in the CI (both for PRs and for scheduled checks) that flag up when anesthetic becomes incompatible with newer pandas and matplotlib versions, then this is something I can get on board with. |
@williamjameshandley, let's get your thoughts on this, too, though. |
Agreed. The current situation means that pip installs break, which is no good at all. The most up-to-date version check could be added as its own dedicated cron job. |
There is an issue with this idea, which is that if the next minor pandas/matplotlib releases and doesn't cause any problems, there's nothing to notify us that we should increment the anesthetic requirements |
A few possible options for subscribing to pypi releases are described here https://stackoverflow.com/questions/17395151/how-can-i-subscribe-to-updates-of-a-package-on-pypi |
How about we add a test that runs after the latest dependencies test and checks whether the latest pandas and matplotlib minor versions are greater than our listed dependency? |
Every time a minor update to pandas or matplotlib is released, inevitably anesthetic breaks. It then takes time to make the necessary changes, which is never as simple as I expect, so we then release a patch to the pyproject.toml which restricts pandas/matplotlib to the previous version, all the while
pip install anesthetic
is broken, which doesn't look good.I propose that we restrict matplotlib and pandas to minor versions which we know work, which once #339 and #335 are finished, will be
numpy and scipy have behaved in the time that I've been working on this project so I think just leave them alone.
To make us aware of new versions, I think we should have a test which tries the latest versions, but does not necessarily need to pass for a PR to be merged.
The text was updated successfully, but these errors were encountered: