Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows partials with slashes, a common partial syntax. For example:
Yes, there are workarounds (cf. handlebars_assets), but the slash syntax is not only widely used but maps directly to template hierarchies, for example from the file system. This is incredibly useful when working in a large template set.
Looking at the parser, it is treating the partial name as a context path (an ID). This does allow the not-very-obvious or intuitive literal syntax:
This commit makes partial names part of the
handlebars
syntax and deliberately removes the old context literal syntax. If necessary for backward compatibility, that could be brought back with a simple change hereRelated issues: #95, #268