Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use cjs for browser fields #1555

Merged
merged 1 commit into from
Sep 20, 2019
Merged

fix: use cjs for browser fields #1555

merged 1 commit into from
Sep 20, 2019

Conversation

paulfalgout
Copy link
Contributor

We should not be using pre-built files for the browser. Resolves #1553

@paulfalgout
fix: use cjs for browser fields
28437a5 
We should not be using pre-built files for the `browser`.  Resolves handlebars-lang#1553
@paulfalgout
Copy link
Contributor Author

Related to #1540
@ouijan I think this PR is a nonbreaking solution with similar, perhaps improved, results for the issue you were seeing with imports. While I think the packaged min.js file may function in some cases, it's breaking in others... But I think these cjs cover your case and the general. If you don't mind 👀 on this.

@nknapp nknapp merged commit c55a7be into handlebars-lang:4.x Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulfalgout @nknapp