From a3aa1590c53cd44b07c71f3dbcf484dcf9999069 Mon Sep 17 00:00:00 2001 From: Kyle Plump Date: Thu, 9 Jan 2025 17:04:39 -0500 Subject: [PATCH 1/2] allow 404, 500 --- lib/hanami/cli/generators/gem/app/gitignore.erb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/hanami/cli/generators/gem/app/gitignore.erb b/lib/hanami/cli/generators/gem/app/gitignore.erb index 4a02040a..3355816c 100644 --- a/lib/hanami/cli/generators/gem/app/gitignore.erb +++ b/lib/hanami/cli/generators/gem/app/gitignore.erb @@ -1,7 +1,9 @@ .env*.local log/* <%- if generate_assets? -%> -public/ +public/* +!public/404.html +!public/500.html node_modules/ <%- end -%> <%- if generate_sqlite? -%> From 8e8bbeb5e074263f454b744daa1e2f41425bd7ae Mon Sep 17 00:00:00 2001 From: Kyle Plump Date: Thu, 9 Jan 2025 17:08:24 -0500 Subject: [PATCH 2/2] updated specs --- spec/unit/hanami/cli/commands/gem/new_spec.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/spec/unit/hanami/cli/commands/gem/new_spec.rb b/spec/unit/hanami/cli/commands/gem/new_spec.rb index dad8eadf..99ed49a0 100644 --- a/spec/unit/hanami/cli/commands/gem/new_spec.rb +++ b/spec/unit/hanami/cli/commands/gem/new_spec.rb @@ -108,7 +108,9 @@ gitignore = <<~EXPECTED .env*.local log/* - public/ + public/* + !public/404.html + !public/500.html node_modules/ db/*.sqlite EXPECTED @@ -586,7 +588,9 @@ class Operation < Dry::Operation gitignore = <<~EXPECTED .env*.local log/* - public/ + public/* + !public/404.html + !public/500.html node_modules/ db/*.sqlite EXPECTED