Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Overall slowness #18

Open
flodel opened this issue Jan 16, 2014 · 1 comment
Open

Overall slowness #18

flodel opened this issue Jan 16, 2014 · 1 comment
Assignees

Comments

@flodel
Copy link

flodel commented Jan 16, 2014

Hi,

When I run multiple tests on a file, a lot of time is wasted running the same things for each test. find_region is the main culprit.

I'd like to suggest that the lint package make use of the memoise package. For example, add memoize(find_region). Doing this made my process run four times faster but I had to insert memoize in an unconventional and hacky way (via unlockBinding, assignInNamespace, etc.).

Thanks for considering it.

@tyner
Copy link

tyner commented Jan 17, 2014

I concur with flodel. Also, dispatch_test seems to cause the file to be read twice:

function (test, file, parse.data = getParseData(parse(file, keep.source = TRUE)), 
          lines = readLines(file), quiet = FALSE, warning = with_default(test$warning, FALSE))

once by parse() and also by readLines().

Thanks

@halpo halpo self-assigned this Mar 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants