Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to support context path #7058

Open
3 tasks done
JohnNiang opened this issue Nov 20, 2024 · 1 comment
Open
3 tasks done

Request to support context path #7058

JohnNiang opened this issue Nov 20, 2024 · 1 comment
Labels
area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider area/theme Issues or PRs related to the Theme Provider kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@JohnNiang
Copy link
Member

Prerequisites

  • I have searched for related issues in the Issues list.
  • This is a feature related to Halo. If it is not an issue with the project itself, it is recommended to submit it in the Discussions.
  • If it is a feature suggestion for plugins and themes, please submit it in the respective plugin and theme repositories.

Your current Halo version

2.20.10-SNAPSHOT

Describe this feature

Currently, more and more users want to run Halo with context path, e.g.: /blog, see the references for more. It's time to evaluate this feature even if we don't support it now.

References

Additional information

/kind feature
/area core
/area theme
/area plugin

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. area/core Issues or PRs related to the Halo Core area/theme Issues or PRs related to the Theme Provider area/plugin Issues or PRs related to the Plugin Provider labels Nov 20, 2024
@ruibaby
Copy link
Member

ruibaby commented Nov 21, 2024

I suggest supporting it in the next major version for the following reasons:

  1. Based on the current version, the changes are too big and I don’t think it is suitable for version 2.x.
  2. The Halo theme and plugin ecosystem may need to be adapted accordingly, and it is appropriate to tell developers that such adaptation is needed in major versions.

@ruibaby ruibaby added this to the Next milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider area/theme Issues or PRs related to the Theme Provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants