Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bibliography #17

Closed
IgnacioRubioScola opened this issue Mar 14, 2022 · 1 comment
Closed

Bibliography #17

IgnacioRubioScola opened this issue Mar 14, 2022 · 1 comment

Comments

@IgnacioRubioScola
Copy link

HI,
Do you have some bibliography explaining the implemented code?
I would like to understand how the algorithm of finding peaks (and the prominences) works
Thank you!
Ignacio

@halleysfifthinc
Copy link
Owner

halleysfifthinc commented Mar 14, 2022

The peak finding algorithm is wholly original, but the prominence algorithm was modeled after the MATLAB documentation description of the relevant algorithms. (I.e. not based on the actual MATLAB code, but their documented description of the behavior.) I don't recall whether the behavior for peak plateaus was based on MATLAB and/or scipy (documentation again, in either case). Behavior for missing/NaNs and strict is mostly original as well.

Also see Topographic prominence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants