Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeafletPlayback not working with leaflet version > 1 #54

Open
stiwari99 opened this issue Apr 24, 2017 · 6 comments
Open

LeafletPlayback not working with leaflet version > 1 #54

stiwari99 opened this issue Apr 24, 2017 · 6 comments

Comments

@stiwari99
Copy link

I am getting following error when trying to use leaflet playback with leaflet version 1.0.3

error: this.callInitHooks is not a function

I am getting this when I call
var playback = L.Playback(map, demoTracks, null, {});
and it seems like error is coming from this piece of code

L.Map.addInitHook(function () {
    if (this.options.playback) {
        this.playback = new L.Playback(this);
    }
});

@answerquest
Copy link

On my end while it's working, when I click and drag the time slider, the map moves with it. So I'm sticking with 0.7.3 for now.

@SFSailor
Copy link

Odd. I am using Leaflet 1.2.0 and it's working "as advertised". Perhaps the latest release fixes your issue. The time slider problem does exist for me too, but I am assuming I can fix that either with some propagation blocking or by using one of the fancier sliders...

@answerquest
Copy link

@SFSailor pls share how you do the propagation blocking.. I haven't been able to figure that out.

@SFSailor
Copy link

I will do that. I had managed it for a custom control, but it seems not to be working yet on the slider. I notice that Weather Underground has the same problem.

@answerquest
Copy link

answerquest commented Nov 27, 2017

If this is abnormal behaviour then should we file an issue in Leaflet? In the past, you'd have to code for propagating clicks through the html element overlaid on the map. Now it's happening by default.

@tfaulkner-eaglegroup
Copy link

I'm getting this same problem on 1.3.1 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants