New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tax rounding fails validation errors #13

Open

SubandiK opened this issue Dec 18, 2024 · 0 comments · May be fixed by #14

Contributor

SubandiK commented Dec 18, 2024 •

edited

Loading

If you have an invoice with an item at a tax rate of 7%, for 2.50 (2.68 including 18c tax), the current validation fails in two places:

comparing the whole invoice (because of forced rounding down it compares 17c to 18c)
comparing on the invoice_item level (because of no rounding at all it compares 17.5c to 18c)

PR incoming

SubandiK linked a pull request

that will close this issue

Fix validation: rounding for subcent amounts #14

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment