You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Helpers.currency_element(xml,'ram','ChargeAmount',gross_amount,currency_code,add_currency: version == 1,digits: 4)
We use item.gross_amount to set ChargeAmount for GrossPriceProductTradePrice.
It turns out that it doesn't actually matter what we pass in there as gross_amount, unless it doesn't work with BigDecimal() all validations pass.
So there is no validation going on besides the type. Is this a problem that should be handled in this gem? Or is this a problem with the existing schemas?
To reproduce just change the gross_amounts in the existing specs, see they don't care.
The text was updated successfully, but these errors were encountered:
Here
ruby-secretariat/lib/secretariat/line_item.rb
Line 109 in ae0e9ac
We use item.gross_amount to set ChargeAmount for GrossPriceProductTradePrice.
It turns out that it doesn't actually matter what we pass in there as gross_amount, unless it doesn't work with BigDecimal() all validations pass.
So there is no validation going on besides the type. Is this a problem that should be handled in this gem? Or is this a problem with the existing schemas?
To reproduce just change the gross_amounts in the existing specs, see they don't care.
The text was updated successfully, but these errors were encountered: