Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InfoClick: Not accepting target attribute on links #1388

Closed
jesade-vbg opened this issue Aug 31, 2023 · 0 comments · Fixed by #1389
Closed

InfoClick: Not accepting target attribute on links #1388

jesade-vbg opened this issue Aug 31, 2023 · 0 comments · Fixed by #1389
Assignees
@jesade-vbg
Labels
bug
Milestone
3.13

Comments

@jesade-vbg
Copy link
Contributor

InfoClick is not accepting anything other than "_blank" as target. It is hardcoded.

The simple fix is to accept attribute target and fallback to "_blank" to keep the previous behaviour.
@jesade-vbg jesade-vbg self-assigned this Aug 31, 2023
@jesade-vbg jesade-vbg added the bug label Aug 31, 2023
@jesade-vbg jesade-vbg added this to the 3.x milestone Aug 31, 2023
@jesade-vbg jesade-vbg mentioned this issue Aug 31, 2023
Merged
@jesade-vbg jesade-vbg linked a pull request Aug 31, 2023 that will close this issue
Accept target attributes in infoclick links #1389
Merged
@jesade-vbg jesade-vbg modified the milestones: 3.x, 3.13 Sep 5, 2023
@github-project-automation github-project-automation bot moved this to Done in Hajk Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jesade-vbg jesade-vbg

Labels
bug
Projects
Hajk
Status: Done
Milestone
3.13
Development

Successfully merging a pull request may close this issue.

Accept target attributes in infoclick links hajkmap/Hajk
2 participants
@jacobwod @jesade-vbg