Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a more generic constructor for rootfs #810

Closed
mcandre opened this issue Sep 19, 2024 · 2 comments
Closed

Implement a more generic constructor for rootfs #810

mcandre opened this issue Sep 19, 2024 · 2 comments
Labels

Comments

@mcandre
Copy link

mcandre commented Sep 19, 2024

os.DirFs(pth) seems to have a fatal design flaw: It invites the user to hardcode either a UNIX (e.g., /) or Windows (e.g., C:) root directory name.

Please implement a 0-ary constructor for filefs that automatically selects an appropriate root directory name in an operating system independent way.

Note that Cygwin environments can reasonably follow UNIX conventions (/); It's not the executable platform so much as the runtime environment.

@hairyhenderson
Copy link
Owner

Thanks for this suggestion - can you give me a concrete example of how you imagine this might look? I'm not sure I'm totally following what the concern is...

Copy link

This issue is stale because it has been open for 60 days with no
activity. If it is no longer relevant or necessary, please close it.
Given no action, it will be closed in 14 days.

If it's still relevant, one of the following will remove the stale
marking:

  • A maintainer can add this issue to a milestone to indicate that
    it's been accepted and will be worked on
  • A maintainer can remove the stale label
  • Anyone can post an update or other comment

@github-actions github-actions bot added the Stale label Nov 20, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants