You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Could it be better for tooling if the error about duplicate names was reported via relevant printer instead of being written to the output? exn and info printers seem to suite well enough.
Although it would probably be a better design, the tooling would have to still support current approach as some existing projects may not get an updated Expecto package anytime soon. Due to this I'm not sure if it'd be a better overall situation for the tools but just wanted to share the thoughts.
Are you sure about exn? It takes both a string and an exception which means we'd have to create some artificial exception probably duplicating the string. It also takes a time span which we don't have, though it could be just 0. info seems to suit better given parameter types it expects.
If sticking with exn, should a separate exception class be added or TestDiscoveryException is OK?
Could it be better for tooling if the error about duplicate names was reported via relevant printer instead of being written to the output?
exn
andinfo
printers seem to suite well enough.Although it would probably be a better design, the tooling would have to still support current approach as some existing projects may not get an updated Expecto package anytime soon. Due to this I'm not sure if it'd be a better overall situation for the tools but just wanted to share the thoughts.
The text was updated successfully, but these errors were encountered: